versions: Improve the loading indicator #10740
Conversation
eth3lbert
added
C-enhancement ✨
|
I need to fix those flaky CI issues that aren't related to this PR. It's quite annoying :/ |
| {{#each this.sortedVersions as |version|}} | ||
| <li> | ||
| <VersionList::Row @version={{version}} local-class="row" data-test-version={{version.num}} /> | ||
| </li> | ||
| {{/each}} | ||
| </ul> | ||
| {{#if this.next_page}} | ||
| {{#if this.loadMoreTask.isRunning}} |
There was a problem hiding this comment.
should we also hide the .page-description element above while this.loadMoreTask.isRunning && this.sortedVersions.count === 0?
There was a problem hiding this comment.
So, this is regarding the initial load (like the 'is-empty' check mentioned above)? I presume this could be achieved via
style="{{unless this.sortedVersions 'visibility:hidden'}}"(which could also be implemented using a CSS class and style).
I don't really have a preference on this, but I think the reasoning behind it is to make it more noticeable that it's still loading and is an initial load. So, I'm okay with this.
I'm also wondering if we should prevent the page loading progress (the yellow one at the top) from completing until the first versions have finished loading.
There was a problem hiding this comment.
should we also hide the
.page-descriptionelement above whilethis.loadMoreTask.isRunning && this.sortedVersions.count === 0?
done!
This shows a loading indicator for the initial load, and a loading button when loading more.
eth3lbert
force-pushed
the
app-versions-loading
branch
from
d920fba to
4dbc9ba
Compare
An excerpt from https://rust-lang.zulipchat.com/#narrow/channel/318791-t-crates-io/topic/swc/near/503007257
This shows a loading indicator for the initial load, and a loading button when loading more :D
Screen.Recording.2025-03-03.at.21.34.36.mov